Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] Simplify logic #72

Merged
merged 10 commits into from
Dec 22, 2023
Merged

[chore] Simplify logic #72

merged 10 commits into from
Dec 22, 2023

Conversation

theBeginner86
Copy link
Contributor

@theBeginner86 theBeginner86 commented Dec 22, 2023 •
edited
Loading

Notes for Reviewers

  1. Simplifies logic for upload through URL or File Path
  2. Updates test workflow for upload through URL
  3. Updates test workflow for upload through File Path
  4. Removes old test workflow which uses applicatoinId as input (this form of input as been deprecated)

This PR fixes #

  • Yes, I signed my commits.

@theBeginner86
rm unwanted step
6316ea6 
Signed-off-by: Pranav Singh <[email protected]>
@theBeginner86
normalize logic
2ebae7a 
Signed-off-by: Pranav Singh <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 22, 2023 •
edited
Loading

@theBeginner86
debug
0b6cdc3 
Signed-off-by: Pranav Singh <[email protected]>
@theBeginner86
debug
04a9e8a 
Signed-off-by: Pranav Singh <[email protected]>
@theBeginner86
fix upload thru path
78cfc72 
Signed-off-by: Pranav Singh <[email protected]>
@theBeginner86
fix upload thru URL
d779d40 
Signed-off-by: Pranav Singh <[email protected]>
@theBeginner86 theBeginner86 added kind/enhancement New feature or request area/ci Continuous Integration labels Dec 22, 2023
@theBeginner86
update
ab5947a 
Signed-off-by: Pranav Singh <[email protected]>
@theBeginner86
rm unwanted defaults
55e29f0 
Signed-off-by: Pranav Singh <[email protected]>
@theBeginner86
rm deprecated test for application id
ea36ac2 
Signed-off-by: Pranav Singh <[email protected]>
@theBeginner86
update
668fc80 
Signed-off-by: Pranav Singh <[email protected]>
@theBeginner86 theBeginner86 merged commit 45bd3d7 into master Dec 22, 2023
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/ci Continuous Integration kind/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@theBeginner86